[WIP]feat: Support apache uniffle remote shuffle service#4884
Draft
wForget wants to merge 3 commits into
Draft
Conversation
Member
Author
|
Most Comet Spark unit tests pass successfully. See: https://github.com/apache/datafusion-comet/actions/runs/29318829876/job/87049939110?pr=4884 The remaining failures are due to:
In a follow-up, I’ll enable only the TPC-H or TPC-DS integration tests for Uniffle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4913.
Rationale for this change
Comet native shuffle currently relies on local shuffle files, which prevents it from being used in deployments backed by a remote shuffle service.
This PR adds Apache Uniffle support while preserving the existing local shuffle path. Comet can push encoded native shuffle blocks to Uniffle and read them back for either regular Spark execution or native shuffle scans.
What changes are included in this PR?
LocalPartitionWriterwrites local data and index files as before.RssPartitionWriterpushes encoded partition data to a remote shuffle service.RssPartitionPusherthat forwards native shuffle data to the JVM.comet-unifflemodule containing:CometUniffleShuffleManagerCometUniffleShuffleWriterCometUniffleShuffleReaderNotes: The initial integration supports native shuffle mode only. JVM columnar shuffle with Uniffle is not supported by this PR.
How are these changes tested?
A dedicated GitHub Actions job:
uniffleprofile.CometUniffleShuffleManager.Most Comet Spark tests pass with Uniffle. The remaining failures are caused by the current native-only limitation and tests that assume deterministic shuffle ordering without an explicit sort.
Test run: https://github.com/apache/datafusion-comet/actions/runs/29318829876/job/87049939110?pr=4884